----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40221/#review106647 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Лис. 16, 2015, 10:29 до полудня, Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40221/ > ----------------------------------------------------------- > > (Updated Лис. 16, 2015, 10:29 до полудня) > > > Review request for Ambari, Sumit Mohanty and Sid Wagle. > > > Bugs: AMBARI-13851 > https://issues.apache.org/jira/browse/AMBARI-13851 > > > Repository: ambari > > > Description > ------- > > AMS scripts should not assume that hdfs is the protocol. > is_hbase_distributed = hbase_root_dir.startswith('hdfs://') > > or > > is_hbase_distributed = > security_params['hbase-site']['hbase.rootdir'].startswith('hdfs://') > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml > 8a5a0f1 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py > 0bdb45f > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py > a1c4581 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py > 00e4123 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 1c6a49f > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > c8114a4 > > ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py > 211c417 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > a97ddc7 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > d3d2c3a > > Diff: https://reviews.apache.org/r/40221/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 249 tests in 8.115s > > OK > ---------------------------------------------------------------------- > Total run:831 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmytro Sen > >
