----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42306/#review114482 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java (line 125) <https://reviews.apache.org/r/42306/#comment175335> I think that this may be a problem in the event a user puts default values in the BP as there is no good way to tell if the user is customizing a value or blindly copying default values. Maybe it might be beneficial to compare the propery value from the BP with the default fromt he stack. If they are different then the user is customizing the value and therefore the Kerberos logic should not change it. However, then there is no way to tell if the user wants to value to remain in it's default state. @rnettleton, any suggestions for this? - Robert Levas On Jan. 14, 2016, 9:59 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42306/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 9:59 a.m.) > > > Review request for Ambari, Robert Levas and Robert Nettleton. > > > Bugs: AMBARI-14668 > https://issues.apache.org/jira/browse/AMBARI-14668 > > > Repository: ambari > > > Description > ------- > > 1) Deploy cluster with HDFS,YARN,Oozie, Storm,Zookeeper. > 2) Enable security. > 3) Customize some properties: hadoop.proxyuser.yarn.hosts, > hadoop.proxyuser.HTTP.groups, oozie.authentication.type, > yarn.timeline-service.http-authentication.type. > 4) Export blueprint config. Check that customized properties are correct in > exported config. > 5) Deploy kerberized cluster via blueprints. > 6) Check that after deploy customized properties are the same as they were > set during customization. > Result: customized properties were reverted. Looks like during BP deploy, we > are just updating all kerberos properties with values from kerberos.json from > related service > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 739cd43 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > c885ca7 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java > 9390b3a > > Diff: https://reviews.apache.org/r/42306/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
