----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42306/#review114488 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java (line 2274) <https://reviews.apache.org/r/42306/#comment175338> I'm almost certain that the "INITIAL_INSTALL" phase is only set when a Blueprints deployment is used. @smohanty can comment on this further. Adding the new "deployType" of "BLUEPRINT" is fine, but may not be necessary, considering my comment above. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java (line 361) <https://reviews.apache.org/r/42306/#comment175339> Again, I'm not sure this separate "deployType" is really needed, since the "INITIAL_INSTALL" phase is set. That being said, it wouldn't necessarily be a bad idea to have this deployType set explicitly. I'm ok with this either way, just wanted to register this comment for possible further review if necessary. ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java (line 125) <https://reviews.apache.org/r/42306/#comment175340> The Stack class can be used to determine if a property is a customized value, or is just a stack default. Please see: org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor#doFilterStackDefaults for an example of how to use the Stack class to determine if the current config property is equal to it's stack default. I'm not sure there's any way to determine the difference between the stack default and a user copying the stack default. - Robert Nettleton On Jan. 14, 2016, 2:59 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42306/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 2:59 p.m.) > > > Review request for Ambari, Robert Levas and Robert Nettleton. > > > Bugs: AMBARI-14668 > https://issues.apache.org/jira/browse/AMBARI-14668 > > > Repository: ambari > > > Description > ------- > > 1) Deploy cluster with HDFS,YARN,Oozie, Storm,Zookeeper. > 2) Enable security. > 3) Customize some properties: hadoop.proxyuser.yarn.hosts, > hadoop.proxyuser.HTTP.groups, oozie.authentication.type, > yarn.timeline-service.http-authentication.type. > 4) Export blueprint config. Check that customized properties are correct in > exported config. > 5) Deploy kerberized cluster via blueprints. > 6) Check that after deploy customized properties are the same as they were > set during customization. > Result: customized properties were reverted. Looks like during BP deploy, we > are just updating all kerberos properties with values from kerberos.json from > related service > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 739cd43 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > c885ca7 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java > 9390b3a > > Diff: https://reviews.apache.org/r/42306/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
