-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42902/
-----------------------------------------------------------
Review request for Ambari, jun aoki and Yusaku Sako.
Bugs: AMBARI-14823
https://issues.apache.org/jira/browse/AMBARI-14823
Repository: ambari
Description
-------
If the error message includes non-ascii string, filter_text fails.
```
Traceback (most recent call last):
File
"/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py",
line 245, in <module>
HiveMetastore().execute()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 219, in execute
method(env)
File
"/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py",
line 60, in start
hive_service('metastore', action='start', upgrade_type=upgrade_type)
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py",
line 89, in thunk
return fn(*args, **kwargs)
File
"/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py",
line 68, in hive_service
pid = get_user_call_output.get_user_call_output(format("cat {pid_file}"),
user=params.hive_user, is_checked_call=False)[1]
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py",
line 58, in get_user_call_output
err_msg = Logger.filter_text(("Execution of '%s' returned %d. %s") %
(command_string, code, all_output))
File "/usr/lib/python2.6/site-packages/resource_management/core/logger.py",
line 98, in filter_text
text.replace(unprotected_string, protected_string)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 117:
ordinal not in range(128)
```
Diffs
-----
ambari-agent/src/test/python/resource_management/TestLogger.py PRE-CREATION
ambari-common/src/main/python/resource_management/core/logger.py fd05b02
Diff: https://reviews.apache.org/r/42902/diff/
Testing
-------
I've manually tested ambari-agent module locally.
```
======================================================================
FAIL: test_generation (TestCertGeneration.TestCertGeneration)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/aajisaka/git/ambari/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
return func(*args, **keywargs)
File
"/Users/aajisaka/git/ambari/ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py",
line 48, in test_generation
self.assertTrue(os.path.exists(self.certMan.getAgentCrtReqName()))
AssertionError
----------------------------------------------------------------------
Ran 423 tests in 9.692s
FAILED (failures=1)
```
The failure looks unrelated to the patch.
Thanks,
Akira Ajisaka
