> On Feb. 17, 2016, 7:52 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh, > > line 21 > > <https://reviews.apache.org/r/43663/diff/1/?file=1252904#file1252904line21> > > > > Why are the table names hardcoded here and not used from the variable > > in pxf-constants?
good point. parameterized table names - bhuvnesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/#review119518 ----------------------------------------------------------- On Feb. 17, 2016, 10:46 p.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43663/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 10:46 p.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Oleksandr Diachenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-15061 > https://issues.apache.org/jira/browse/AMBARI-15061 > > > Repository: ambari > > > Description > ------- > > During PXF service check, in order to execute hbase / hive command, we do > initialize the shell everytime (hbase shell / hive) and then run the command. > Initializing the shell takes time and we do that around 3-4 times which > consumes majority of the time. > We should initialize the shell once, and execute the commands using a file > instead of doing individually. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-cleanup-data.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py > b3e85e4 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py > 9d93a38 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py > 21b7c5d > > Diff: https://reviews.apache.org/r/43663/diff/ > > > Testing > ------- > > yes. manual. > > > Thanks, > > bhuvnesh chaudhary > >
