> On Feb. 19, 2016, 1:37 a.m., jun aoki wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-cleanup-data.sh, > > line 22 > > <https://reviews.apache.org/r/43663/diff/2/?file=1253298#file1253298line22> > > > > Could this be InlineTemplate?
will do > On Feb. 19, 2016, 1:37 a.m., jun aoki wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh, > > line 22 > > <https://reviews.apache.org/r/43663/diff/2/?file=1253299#file1253299line22> > > > > Could this be InlineTemplate? will do > On Feb. 19, 2016, 1:37 a.m., jun aoki wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py, > > line 27 > > <https://reviews.apache.org/r/43663/diff/2/?file=1253301#file1253301line27> > > > > will be nice if we have more consistent naming ? > > e.g. > > ``` > > hbase_populate_data_script = "hbase-populate-data.sh" > > hbase_cleanup_data_script = "hbase-cleanup-data.sh" > > ``` will do > On Feb. 19, 2016, 1:37 a.m., jun aoki wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py, > > line 266 > > <https://reviews.apache.org/r/43663/diff/2/?file=1253302#file1253302line266> > > > > how about > > ``` > > > > def __create_hbase_script(self, script_name) > > File("{0}/{1}".format(params.exec_tmp_dir, script_name), > > content=StaticFile("{0}".format(script_name)), > > mode=0755) > > > > ... > > > > # caller > > __create_hbase_script(pxf_constants.hbase_load_script) > > __create_hbase_script(pxf_constants.hbase_cleanup_script) > > ``` Makes sense, but since its used only 2 times, would not prefer creating another wrapper over File here. > On Feb. 19, 2016, 1:37 a.m., jun aoki wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py, > > line 329 > > <https://reviews.apache.org/r/43663/diff/2/?file=1253302#file1253302line329> > > > > At this point, it is guaranteed the table does not exist? hbase script to populate data has the commands to disable and drop before creating, so yes, it will take care of it. - bhuvnesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/#review119764 ----------------------------------------------------------- On Feb. 17, 2016, 10:46 p.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43663/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 10:46 p.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Oleksandr Diachenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-15061 > https://issues.apache.org/jira/browse/AMBARI-15061 > > > Repository: ambari > > > Description > ------- > > During PXF service check, in order to execute hbase / hive command, we do > initialize the shell everytime (hbase shell / hive) and then run the command. > Initializing the shell takes time and we do that around 3-4 times which > consumes majority of the time. > We should initialize the shell once, and execute the commands using a file > instead of doing individually. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-cleanup-data.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py > b3e85e4 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py > 9d93a38 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py > 21b7c5d > > Diff: https://reviews.apache.org/r/43663/diff/ > > > Testing > ------- > > yes. manual. > > > Thanks, > > bhuvnesh chaudhary > >
