[GitHub] [ambari] eubnara commented on a diff in pull request #3354: AMBARI-25719. Fail to enable kerberos due to NullPointerException and HostNotFoundException

[GitBox]

eubnara commented on code in PR #3354:
URL: https://github.com/apache/ambari/pull/3354#discussion_r957828447


##########
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AgentCommandsPublisher.java:
##########
@@ -111,7 +111,10 @@ public void sendAgentCommand(Multimap<Long, AgentCommand> 
agentCommands) throws
                 if (!clusterDesiredConfigs.containsKey(clusterId)) {
                   clusterDesiredConfigs.put(clusterId, 
clusters.getCluster(clusterId).getDesiredConfigs());
                 }
-              } catch (NumberFormatException|AmbariException ignored) {}
+              } catch (NumberFormatException|AmbariException e) {
+                LOG.error("Exception on sendAgentCommand", e);
+                throw new RuntimeException(e);

Review Comment:
   Could I change `RuntimeException` to `AmbariException` ?
   If I don't rethrow the exception, it hangs on `Test Kerberos Client` or 
`Distribute Keytabs` and you would wait until it gets timeout.
   
![image](https://user-images.githubusercontent.com/12639125/187306260-316615b7-b558-4ef3-b4c9-07916d39d09e.png)
   
![image](https://user-images.githubusercontent.com/12639125/187306270-a2412d0d-f5bb-4341-bbeb-c3effa291199.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org