eubnara commented on code in PR #3354:
URL: https://github.com/apache/ambari/pull/3354#discussion_r961181581
##########
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AgentCommandsPublisher.java:
##########
@@ -111,7 +111,10 @@ public void sendAgentCommand(Multimap<Long, AgentCommand>
agentCommands) throws
if (!clusterDesiredConfigs.containsKey(clusterId)) {
clusterDesiredConfigs.put(clusterId,
clusters.getCluster(clusterId).getDesiredConfigs());
}
- } catch (NumberFormatException|AmbariException ignored) {}
+ } catch (NumberFormatException|AmbariException e) {
+ LOG.error("Exception on sendAgentCommand", e);
+ throw new AmbariRuntimeException(e);
Review Comment:
Oh, wait please.
When installing new cluster, `NumberFormatException` raises because there is
no cluster id for new cluster yet on line `clusterId =
Long.valueOf(((ExecutionCommand)ac).getClusterId());`.
It hangs and cannot proceed next stages.
I'll fix it wait please.
```
2022-09-02 07:55:34,472 ERROR [agent-command-publisher-1]
AgentCommandsPublisher:115 - Exception on sendAgentCommand
java.lang.NumberFormatException: null
at java.lang.Long.parseLong(Long.java:552)
at java.lang.Long.valueOf(Long.java:803)
at
org.apache.ambari.server.events.publishers.AgentCommandsPublisher.lambda$null$0(AgentCommandsPublisher.java:110)
at
java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at
com.google.common.collect.CollectSpliterators$1.lambda$forEachRemaining$1(CollectSpliterators.java:116)
at
java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384)
at
com.google.common.collect.CollectSpliterators$1.forEachRemaining(CollectSpliterators.java:116)
at
com.google.common.collect.CollectSpliterators$1FlatMapSpliterator.lambda$forEachRemaining$1(CollectSpliterators.java:247)
at
java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1723)
at
com.google.common.collect.CollectSpliterators$1FlatMapSpliterator.forEachRemaining(CollectSpliterators.java:247)
at
java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at
java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at
java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
at java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:401)
at java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:734)
at
java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at
java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at
java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at
java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
at
java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:650)
at
org.apache.ambari.server.events.publishers.AgentCommandsPublisher.lambda$sendAgentCommand$1(AgentCommandsPublisher.java:103)
at
java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1386)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
at
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
at
java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
at
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
