kevinw66 commented on code in PR #3364: URL: https://github.com/apache/ambari/pull/3364#discussion_r990239746
########## ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql: ########## @@ -26,16 +26,6 @@ delimiter ; # USE @schema; --- Set default_storage_engine to InnoDB --- storage_engine variable should be used for versions prior to MySQL 5.6 -set @version_short = substring_index(@@version, '.', 2); -set @major = cast(substring_index(@version_short, '.', 1) as SIGNED); -set @minor = cast(substring_index(@version_short, '.', -1) as SIGNED); -set @engine_stmt = IF(@major >= 5 AND @minor>=6, 'SET default_storage_engine=INNODB', 'SET storage_engine=INNODB'); -prepare statement from @engine_stmt; -execute statement; -DEALLOCATE PREPARE statement; - Review Comment: Will it be better if we can simply replace the condition with `(@major >= 5 AND @minor>=6) or @major >= 8`? Since mysql8 is also use `default_storage_engine` as variable name but the current condition cannot cover it? I'm not sure if we will meet unexpected behaviors in old versions if we delete these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
