kevinw66 commented on code in PR #3364: URL: https://github.com/apache/ambari/pull/3364#discussion_r990335931
########## ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql: ########## @@ -26,16 +26,6 @@ delimiter ; # USE @schema; --- Set default_storage_engine to InnoDB --- storage_engine variable should be used for versions prior to MySQL 5.6 -set @version_short = substring_index(@@version, '.', 2); -set @major = cast(substring_index(@version_short, '.', 1) as SIGNED); -set @minor = cast(substring_index(@version_short, '.', -1) as SIGNED); -set @engine_stmt = IF(@major >= 5 AND @minor>=6, 'SET default_storage_engine=INNODB', 'SET storage_engine=INNODB'); -prepare statement from @engine_stmt; -execute statement; -DEALLOCATE PREPARE statement; - Review Comment: I know. I mean, the condition `@major >= 5 AND @minor>=6` we are using now returns false when mysql version is 8.0, we can simply use `(@major >= 5 AND @minor>=6) or @major >= 8` to make it returns true, and avoid behavior changes when mysql version lower than 5.6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
