zRains commented on PR #3967:
URL: https://github.com/apache/ambari/pull/3967#issuecomment-2788573351

   
   Thanks to @chenyuan99 and @vanshuhassija ! As mentioned by chenyuan99, we 
should totally lean into the perks of componentization. Combining that with the 
“switch experience” idea, I’d like to throw out a suggestion that I think could 
work nicely:
   
   
![2024-05-24-1456](https://github.com/user-attachments/assets/6835857c-3f69-4de4-bcae-2619bf4fbbb0)
   
   The frontend code for ambari-admin would move into ambari-web-next as a 
package, and the React-refactored ambari-web would also live there as its own 
package. Shared components (like buttons, tables, etc.) would be handled by a 
ui-shared package. Meanwhile, the classic ambari-web stays untouched.
   
   Here’s how it could look:
   
   ```text
   ├── ambari-admin
   ├── ambari-funtest
   ├── ambari-project
   ├── ambari-server
   ├── ambari-server-spi
   ├── ambari-serviceadvisor
   ├── ambari-utility
   ├── ambari-views
   ├── ambari-web
   │   ├── api-docs
   │   ├── app
   │   └── ...
   ├── ambari-web-next
   │   ├── web
   │   ├── admin
   │   ├── package.json
   │   └── ...
   ├── ...
   └── version
   ```
   
   Here’s what we’d get out of it:
   
   1. With pnpm workspace, we’re not just sharing components—we’d also share 
dependencies and keep versions in sync. That’d speed up dev and builds(CI/CD) 
time.
   
   2. Keeping the original ambari-web as-is means we don’t have to mess with 
existing docs or guides (though admin might still need some tweaks). We can 
focus on writing fresh docs for the refactored projects.
   
   3. Moving ambari-web would bundle in vanshuhassija’s change commits, which 
might make tracking issues a bit trickier. This can be avoided.
   
   For the “switch experience,” we could tweak the URL prefix to make it 
happen—maybe even throw in a button for it? What do you all think, @chenyuan99 
@vanshuhassija @arshadmohammad @nikita15p @JiaLiangC thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org

Reply via email to