vishalsuvagia commented on PR #3967: URL: https://github.com/apache/ambari/pull/3967#issuecomment-2871893511
+1 LGTM, @zRains , can you kindly review the patch. The discussion here seems out of scope of the patch. we can have a separate mail discussion or in a jira ticket with the task for unification of front-end components. Also if you kindly check [here](https://github.com/apache/ambari/pull/3963#issuecomment-2756892597), I had asked @chenyuan99 to share a design document for the same in a jira or through a mail thread where we can discuss the pro's and con's of the approach as well as look into covering the major use cases we would like to target for unification of the same. We are in favour of the unification of the modules, but we can achieve it easily if we have the admin and web modules migrated to react implementation. The patch here is only adding switchable experience to a react equivalent of the existing implementation which would be anyways useful and handy when we take up the unification task(just need to move the newer implementation to a new module). A significant proportion of the re-write to react implementation has been achieved and will be shortly published for review once this patch is reviewed and merged, that would make it easier to achieve the unification task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
