I've been thinking about suggesting this before, but now that the trunk has 
broken (undesired) changes that worked fine in beta-2, it might be a good idea 
to postpone most of the outstanding issues for RC1 to a RC2 and release RC1 
asap. 
 
That would promote better testing of the 100+ bug-fixes and changes since 
beta-2. Incidentally, beta-2 is now 4 months old, which was also the timeframe 
between beta-1 and beta-2. 
 
Erik-Berndt 

________________________________

Van: Maarten Coene [mailto:[EMAIL PROTECTED]
Verzonden: do 17-7-2008 11:45
Aan: Ant Developers List
Onderwerp: [SPAM] Re: Ivy svn breaks ant-contrib svn



Just a wild guess, but maybe you could use IvyAntSettings again (like your 
original code was), but instead of calling the execute method you can register 
it yourself as Reference in the Project, something like:

IvyAntSettings settings = new IvyAntSettings();
settings.setXXX...
getProject().addReference(settingsId, settings);

Maarten




----- Original Message ----
From: Stefan Bodewig <[EMAIL PROTECTED]>
To: dev@ant.apache.org
Sent: Tuesday, July 15, 2008 2:13:10 PM
Subject: Re: Ivy svn breaks ant-contrib svn

On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote:

> On Tue, Jul 15, 2008 at 9:23 AM, Stefan Bodewig <[EMAIL PROTECTED]> wrote:
>
> > On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote:
> >
> > > On Tue, Jul 15, 2008 at 8:53 AM, Stefan Bodewig <[EMAIL PROTECTED]>
> > wrote:
> > >
> > > > Ant-contrib also invokes setId() on the task, which works fine with
> > > > Ivy 2.0.0beta2 but fails with trunk.
> > > >
> > > > Could you please re-add the setid method?
> > >
> > > setId is now setSettingsId on IvyConfigure, which is more in
> > > conformance with Ant, since we are not setting the id of the
> > > task, but of the underneath datatype.
> >
> > OK, what can ant-contrib do if it wants to compile against Ivy
> > 2.0.0beta2 and trunk with the same codebase?
>
> This is not straightforward, since we broke the API.

Right, that's why Gump finds it 8-)

Maybe you could throw in a deprecated setId() method that delegated to
setSettingsId()?  At least for the next beta so ant-contrib has a
stable base to work from without resorting to reflection.

I looked into the code to see what the id is used for.  It is later
used as the argument for IvyCacheFileset.setSettingsRef - this
wouldn't work with a reference to the task but would require a
reference to the settings, which now would exactly be what
setSettingsId creates, right?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


     

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Disclaimer:
This message contains information that may be privileged or confidential and is 
the property of Sogeti Nederland B.V. or its Group members. It is intended only 
for the person to whom it is addressed. If you are not the intended recipient, 
you are not authorized to read, print, retain, copy, disseminate, distribute, 
or use this message or any part thereof. If you receive this message in error, 
please notify the sender immediately and delete all copies of this message.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to