bodewig commented on a change in pull request #90: solve the unconsistent
comments
URL: https://github.com/apache/ant/pull/90#discussion_r273119872
##########
File path: src/main/org/apache/tools/ant/UnknownElement.java
##########
@@ -151,11 +151,7 @@ public RuntimeConfigurable getWrapper() {
}
/**
- * Creates the real object instance and child elements, then configures
- * the attributes and text of the real object. This unknown element
- * is then replaced with the real object in the containing target's list
- * of children.
- *
+ * Configure the given object from this UnknownElement
Review comment:
This replaces a somewhat lengthy detailed description of what happens by a
less clear one-liner. Why is this better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
