bodewig commented on a change in pull request #90: solve the unconsistent 
comments 
URL: https://github.com/apache/ant/pull/90#discussion_r273120166
 
 

 ##########
 File path: src/main/org/apache/tools/ant/types/XMLCatalog.java
 ##########
 @@ -197,10 +197,7 @@ public Path createClasspath() {
     }
 
     /**
-     * Allows simple classpath string.  Not allowed if this catalog is
-     * itself a reference to another catalog -- that is, a catalog
-     * cannot both refer to another <em>and</em> contain elements or
-     * other attributes.
+     * Append the contents of the other Path instance to this.
 
 Review comment:
   This replaces a somewhat lengthy detailed description of what happens by a 
less clear one-liner. Why is this better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Reply via email to