bodewig commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r460786692
##########
File path: src/main/org/apache/tools/ant/listener/Log4jListener.java
##########
@@ -142,21 +142,17 @@ public void messageLogged(final BuildEvent event) {
final Logger log
= Logger.getLogger(categoryObject.getClass().getName());
switch (event.getPriority()) {
- case Project.MSG_ERR:
- log.error(event.getMessage());
- break;
case Project.MSG_WARN:
log.warn(event.getMessage());
break;
case Project.MSG_INFO:
log.info(event.getMessage());
break;
case Project.MSG_VERBOSE:
- log.debug(event.getMessage());
- break;
case Project.MSG_DEBUG:
log.debug(event.getMessage());
break;
+ case Project.MSG_ERR:
Review comment:
Personally I prefer the explicit case over a fallthrough to the default
case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
