bodewig commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r460787528
##########
File path: src/main/org/apache/tools/ant/taskdefs/MacroInstance.java
##########
@@ -221,8 +221,6 @@ private String macroSubs(String s, Map<String, String>
macroMapping) {
}
}
switch (state) {
- case STATE_NORMAL:
- break;
Review comment:
To me the explicit case makes it easier to see what happens than having
to look up the default case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
