[
https://issues.apache.org/jira/browse/APEXCORE-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368613#comment-15368613
]
ASF GitHub Bot commented on APEXCORE-222:
-----------------------------------------
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/350#discussion_r70151318
--- Diff:
bufferserver/src/main/java/com/datatorrent/bufferserver/server/Server.java ---
@@ -169,7 +168,7 @@ public String toString()
return identity;
}
- private final HashMap<String, DataList> publisherBuffers = new
HashMap<String, DataList>();
+ private final ConcurrentHashMap<String, DataList> publisherBuffers = new
ConcurrentHashMap<String, DataList>();
--- End diff --
Please use 1 for concurrency level instead of default 16. There is only one
thread that modifies publisherBuffers. Use default 0.75f for the load factor
and 1 as the initial capacity.
> Delegate Buffer Server purge to StreamingContainer
> --------------------------------------------------
>
> Key: APEXCORE-222
> URL: https://issues.apache.org/jira/browse/APEXCORE-222
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Thomas Weise
> Assignee: Sandesh
>
> Currently the purge requests are sent to the buffer servers from the app
> master. This interaction exists parallel to the heartbeat protocol. Instead,
> the committed window ID that is propagated through the heartbeat response can
> be used in StreamingContainer to initiate the purge with the local buffer
> server, similar to how the committed callback on the operator occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
