[ https://issues.apache.org/jira/browse/APEXCORE-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379679#comment-15379679 ]
ASF GitHub Bot commented on APEXCORE-222: ----------------------------------------- Github user gauravgopi123 commented on a diff in the pull request: https://github.com/apache/apex-core/pull/350#discussion_r71005395 --- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/DataList.java --- @@ -176,21 +176,20 @@ public void reset() numberOfInMemBlockPermits.set(MAX_COUNT_OF_INMEM_BLOCKS - 1); } - public void purge(final int baseSeconds, final int windowId) + public void purge(long windowId) --- End diff -- should windowId be made final? > Delegate Buffer Server purge to StreamingContainer > -------------------------------------------------- > > Key: APEXCORE-222 > URL: https://issues.apache.org/jira/browse/APEXCORE-222 > Project: Apache Apex Core > Issue Type: Improvement > Reporter: Thomas Weise > Assignee: Sandesh > > Currently the purge requests are sent to the buffer servers from the app > master. This interaction exists parallel to the heartbeat protocol. Instead, > the committed window ID that is propagated through the heartbeat response can > be used in StreamingContainer to initiate the purge with the local buffer > server, similar to how the committed callback on the operator occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)