[
https://issues.apache.org/jira/browse/APEXCORE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379496#comment-15379496
]
ASF GitHub Bot commented on APEXCORE-482:
-----------------------------------------
GitHub user sandeshh opened a pull request:
https://github.com/apache/apex-core/pull/358
*Review only* [APEXCORE-482]Make the downstream operator & unifier in the
same container as THREA…
…D_LOCAL
Opening it early, to get the feedback on the approach.
Note:
Added the locality field. The reason for that is StreamMeta is shared with
the upstream operator, so changing the locality in the Unifier affects the
upstream as well, but it is not required.
TODO: Add unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandeshh/apex-core APEXCORE-482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-core/pull/358.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #358
----
commit dbcf00729aaaf595c8d11b020f81a18c5f5a1e42
Author: sandeshh <[email protected]>
Date: 2016-07-15T14:38:30Z
Make the downstream operator & unifier in the same container as THREAD_LOCAL
----
> Default Unifiers should be ThreadLocal with downstream operators
> ----------------------------------------------------------------
>
> Key: APEXCORE-482
> URL: https://issues.apache.org/jira/browse/APEXCORE-482
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Sandesh
> Assignee: Sandesh
>
> Default Unifiers are currently deployed ( except in Mx1 ) as CONTAINER_LOCAL
> with the downstream operator. It is better to make it THREAD_LOCAL to improve
> the performance.
> Custom unifiers can still be CONTAINER_LOCAL and possibly allow the users to
> control the behaviours.
> Note: Created a prototype to understand the root cause :
> https://github.com/sandeshh/apex-core/commit/550f31c770b704360c813924e85a9fffeaec7c53
> During PhysicalPlan creation downstream operator's input port won't have
> stream locality assigned. So StreamingContainerAgent assigns CONTAINER_LOCAL
> Actual implementation should be done in Physical Plan.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
