[
https://issues.apache.org/jira/browse/APEXCORE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396072#comment-15396072
]
ASF GitHub Bot commented on APEXCORE-482:
-----------------------------------------
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/358#discussion_r72490943
--- Diff:
engine/src/main/java/com/datatorrent/stram/plan/physical/PTOperator.java ---
@@ -85,6 +85,7 @@
private static final long serialVersionUID = 201312112033L;
public final LogicalPlan.StreamMeta logicalStream;
+ public Locality locality;
--- End diff --
StreamMeta is shared with the upstream operator, so changing that has
unwanted side effects. I am exploring the options to create a new StreamMeta
object for each Unifiers.
> Default Unifiers should be ThreadLocal with downstream operators
> ----------------------------------------------------------------
>
> Key: APEXCORE-482
> URL: https://issues.apache.org/jira/browse/APEXCORE-482
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Sandesh
> Assignee: Sandesh
>
> Default Unifiers are currently deployed ( except in Mx1 ) as CONTAINER_LOCAL
> with the downstream operator. It is better to make it THREAD_LOCAL to improve
> the performance.
> Custom unifiers can still be CONTAINER_LOCAL and possibly allow the users to
> control the behaviours.
> Note: Created a prototype to understand the root cause :
> https://github.com/sandeshh/apex-core/commit/550f31c770b704360c813924e85a9fffeaec7c53
> During PhysicalPlan creation downstream operator's input port won't have
> stream locality assigned. So StreamingContainerAgent assigns CONTAINER_LOCAL
> Actual implementation should be done in Physical Plan.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
