[ 
https://issues.apache.org/jira/browse/APEXCORE-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389935#comment-15389935
 ] 

ASF GitHub Bot commented on APEXCORE-495:
-----------------------------------------

Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/360#discussion_r71919873
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/cli/ApexCli.java ---
    @@ -3715,6 +3718,50 @@ DTConfiguration 
getLaunchAppPackageProperties(AppPackage ap, ConfigPackage cp, L
         return launchProperties;
       }
     
    +  private List<AppInfo> getAppsFromPackageAndConfig(AppPackage ap, 
ConfigPackage cp, boolean onlyConfigApps)
    +  {
    +    if (cp == null) {
    +      return ap.getApplications();
    +    }
    +
    +    File src = new File(cp.tempDirectory(), "app");
    +    File dest = new File(ap.tempDirectory(), "app");
    +
    +    if (!src.exists()) {
    +      return ap.getApplications();
    +    }
    +
    +    if (onlyConfigApps) {
    +      try {
    +        FileUtils.cleanDirectory(dest);
    +      } catch (IOException e) {
    +        e.printStackTrace();
    --- End diff --
    
    Need appropriate exception handling


> Enhancing the configuration package to store apps
> -------------------------------------------------
>
>                 Key: APEXCORE-495
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-495
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Sandesh
>            Assignee: Sandesh
>
> Apex supports configuration package, separates application package from the 
> actual configuration. (http://docs.datatorrent.com/configuration_packages/)
> We want to enhance the configuration package by adding support to "add Apps" 
> (json format). 
> UseCase: Multiple users sharing the same app package, but have a different 
> view of the golden copy of the app package.
> Note: This feature is requested by an Apex user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to