[
https://issues.apache.org/jira/browse/APEXCORE-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389947#comment-15389947
]
ASF GitHub Bot commented on APEXCORE-495:
-----------------------------------------
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r71920323
--- Diff: engine/src/main/java/com/datatorrent/stram/client/AppPackage.java
---
@@ -371,23 +376,12 @@ private void processAppDirectory(File dir)
for (File entry : files) {
if (entry.getName().endsWith(".json")) {
appJsonFiles.add(entry.getName());
- try {
- AppFactory appFactory = new
StramAppLauncher.JsonFileAppFactory(entry);
- StramAppLauncher stramAppLauncher = new
StramAppLauncher(entry.getName(), config);
- stramAppLauncher.loadDependencies();
- AppInfo appInfo = new AppInfo(appFactory.getName(),
entry.getName(), "json");
- appInfo.displayName = appFactory.getDisplayName();
- try {
- appInfo.dag =
appFactory.createApp(stramAppLauncher.getLogicalPlanConfiguration());
- appInfo.dag.validate();
- } catch (Exception ex) {
- appInfo.error = ex.getMessage();
- appInfo.errorStackTrace = ExceptionUtils.getStackTrace(ex);
- }
+ AppInfo appInfo = jsonFileToAppInfo(entry,config);
+
+ if (appInfo != null) {
applications.add(appInfo);
- } catch (Exception ex) {
- LOG.error("Caught exceptions trying to process {}",
entry.getName(), ex);
--- End diff --
Ditto above
> Enhancing the configuration package to store apps
> -------------------------------------------------
>
> Key: APEXCORE-495
> URL: https://issues.apache.org/jira/browse/APEXCORE-495
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Sandesh
> Assignee: Sandesh
>
> Apex supports configuration package, separates application package from the
> actual configuration. (http://docs.datatorrent.com/configuration_packages/)
> We want to enhance the configuration package by adding support to "add Apps"
> (json format).
> UseCase: Multiple users sharing the same app package, but have a different
> view of the golden copy of the app package.
> Note: This feature is requested by an Apex user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
