Github user sanjaypujare commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/347#discussion_r73019499
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
    @@ -143,7 +172,7 @@ public void setConnectionFactoryProperties(Map<String, 
String> connectionFactory
       @Deprecated
       public void setUser(String user)
    --- End diff --
    
    Good point. I will go ahead and ask dev & users about 
connectionFactoryClass. In the mean time will think and discuss about which 
option to go with (remove the convenience functions or mark them deprecated).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to