Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/347#discussion_r73784565
--- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
@@ -129,12 +173,20 @@ public void setConnectionFactoryClass(String
connectionFactoryClass)
*/
public Map<String, String> getConnectionFactoryProperties()
{
- return connectionFactoryProperties;
+ if (connectionFactoryBuilder instanceof
DefaultConnectionFactoryBuilder) {
--- End diff --
On further thought about the serialization aspects and the extra objects,
it would create, suggest having the connectionFactoryBuilder null by default
and creating it in the helper method. So if connectionFactoryBuilder is null or
not instance of DefaultConnectionFactoryBuilder set it to a new
DefaultConnectionFactoryBuilder. If someone sets a different factory builder
then an extra default builder will not be used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
