During release, I see following JIRAs issues repeating: Contributors:
- tickets created without description - please always provide a description that others can understand - tickets created with lengthy titles - keep the title short and put details into description and comments - before working on a JIRA, make sure it is assigned to you Reviewers: - check that JIRA has all details before reviewing PR - check that JIRA summarizes the solution - resolve JIRA and *set fix version* when merging PR Thanks On Fri, Mar 24, 2017 at 8:38 AM, Thomas Weise <t...@apache.org> wrote: > +1 > > There are also cases where PRs have been under review by multiple people > that are suddenly unilaterally rebased and merged. > > Furthermore those that review and merge should follow the contributor > guidelines (or improve them). For example, JIRAs are supposed to be > resolved and marked with the fix version when the PR is merged. > > Thomas > > > > > > > On Thu, Mar 23, 2017 at 12:58 PM, Vlad Rozov <v.ro...@datatorrent.com> > wrote: > >> Lately there were few instances where PR open against apex-core and >> apex-malhar were merged just few hours after it being open and JIRA being >> raised without giving chance for other contributors to review and comment. >> I'd suggest that we stop such practice no matter how trivial those changes >> are. This equally applies to documentation. In a rear cases where PR is >> urgent (for example one that fixes compilation error), I'd suggest that a >> committer who plans to merge the PR sends an explicit notification to >> dev@apex and gives others a reasonable time to respond. >> >> Thank you, >> >> Vlad >> >> >
