Vlad, are you asking for a consensus on the policy to make it official
(publish on website etc). I believe we have one. However, I did not see
much difference between what you said on Mar 26th to what I proposed on Mar
24th. Is the main difference any committer can merge (not just the main
reviewer) as long as there are no objections from others. In that case, I
am fine with it.

On Thu, Apr 27, 2017 at 7:44 AM, Vlad Rozov <v.ro...@datatorrent.com> wrote:

> This is a friendly reminder regarding PR merge policy.
>
> Thank you,
>
> Vlad
>
>
> On 3/23/17 12:58, Vlad Rozov wrote:
>
>> Lately there were few instances where PR open against apex-core and
>> apex-malhar were merged just few hours after it being open and JIRA being
>> raised without giving chance for other contributors to review and comment.
>> I'd suggest that we stop such practice no matter how trivial those changes
>> are. This equally applies to documentation. In a rear cases where PR is
>> urgent (for example one that fixes compilation error), I'd suggest that a
>> committer who plans to merge the PR sends an explicit notification to
>> dev@apex and gives others a reasonable time to respond.
>>
>> Thank you,
>>
>> Vlad
>>
>>
>

Reply via email to