I too agree with the sentiments expressed here and good to know there are people who think like me.
In terms of examples, you can see the PR https://github.com/apache/apex-core/pull/569 which has a long discussion about failing tests and who has the onus to prove what etc. In a recent PR that abossert <https://github.com/apache/apex-core/issues?q=is%3Apr+is%3Aopen+author%3Aabossert> opened, Vlad threatened to -1 an idea that was not even suggested ( https://github.com/apache/apex-core/pull/607#discussion_r248498412) . As Amol mentioned vetoes are not rare here and I didn't have to wait too long for an example to turn up. On Tue, Jan 29, 2019 at 3:14 PM amol kekre <amolhke...@gmail.com> wrote: > Justin, > I agree with your thoughts. Vetos are not rare in Apex. We are trying to > figure a way to get there. > > Amol > > On Tue, Jan 29, 2019 at 3:01 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > If someone submits what you think is poor quality code just point it out > > to them and ask them to fix it or even better fix it yourself to show > them > > what is expected. Vetoing something list that seems a little heavy handed > > and is not the best way to encourage community growth. It’s better to > > improve the quality of others contributions rather than blocking them > from > > contributing. Vetos in practice are very rare, how many have actually > > occurred in this project? Wouldn't it be better to focus on practical > ways > > to get people involved and increase contribution rather than hypothetical > > situations of when to veto a code change? > > > > Thanks, > > Justin >
