Hi, IMO let's not spend lot of time in digging up past just to check proofs for people's opinion like hight bar for code submission or long pending reviews. If it's a common feeling amongst most of committers and they are saying it, we should find some way to work our way to improve things. May be we do monitor next 5-10 PRs closely and then refine our policies "if required", rather than spending lot of time in finding old PRs and trying to remember what happened back then.
-Priyanka On Wed, Jan 30, 2019 at 10:06 AM Vlad Rozov <vro...@apache.org> wrote: > > > > On Jan 29, 2019, at 20:04, Justin Mclean <jus...@classsoftware.com> > wrote: > > > > Hi, > > > >> Badly written code, missing and failing unit tests make it harder for > everyone to contribute. > > > > IMO having code that can be easily improved makes it easier for people > to contribute. > > Possibly you are interested in fixing badly written code but my prior > experience is that developers are more interested in implementing new > features and functionality. Personally, I prefer to stay away from badly > designed and written code. > > > > >> Justin, -1 are infrequent during PR reviews in Apex. > > > > I could easily find 5 from a quick search, which in my experience is > unusual, but it may be different on other projects. Most projects I’ve been > involved in almost never have vetos as things are usually sorted out by > discussion or worked on colatoratively to find a solution before it gets to > that point. Can I suggest in future rather than casting a veto right away > people try and work with the person who made the contribution and improve > what they have contributed. > > Please list them all here and let’s take a look whether or not -1 were > justified on a case by case basis. > > > > > Thanks, > > Justin > >
