[
https://issues.apache.org/jira/browse/APEXMALHAR-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113179#comment-15113179
]
ASF GitHub Bot commented on APEXMALHAR-1983:
--------------------------------------------
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/176#discussion_r50596279
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -366,17 +366,17 @@ public String getClusters()
return Joiner.on(';').join(clusters);
}
- public void setTopics(String... topics)
+ public void setTopics(String topics)
{
- this.topics = topics;
+ this.topics = topics.split(",");
--- End diff --
Please add javadoc that mentions that `,` is used for splitting.
Does it make sense to let user define this separator?
Is this not an API change?
> Support special chars in topics setting for new Kafka Input Operator
> --------------------------------------------------------------------
>
> Key: APEXMALHAR-1983
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-1983
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Siyuan Hua
> Assignee: Siyuan Hua
> Fix For: 3.4.0
>
>
> The setter method take string[] as parameter which confuse the json
> serializer which character as separator. We should convert the string to
> string[] in setter method. Reserve , as seperator
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
