[
https://issues.apache.org/jira/browse/APEXMALHAR-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123874#comment-15123874
]
ASF GitHub Bot commented on APEXMALHAR-1983:
--------------------------------------------
Github user siyuanh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/176#discussion_r51292122
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -366,17 +374,19 @@ public String getClusters()
return Joiner.on(';').join(clusters);
}
- public void setTopics(String... topics)
+ public void setTopics(String topics)
{
- this.topics = topics;
+ Topic.validate(topics.replace(" |,", "");
--- End diff --
valid topic + valid topic is valid invalid topic + valid topic is invalid
I know there is one exception here "a b, c" will be treated as valid but
this is just a fast fail. A topic contain space in the middle will eventually
throw exception.
To keep it simple I did this quick shortcut validation.
And there is no false negative
> Support special chars in topics setting for new Kafka Input Operator
> --------------------------------------------------------------------
>
> Key: APEXMALHAR-1983
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-1983
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Siyuan Hua
> Assignee: Siyuan Hua
> Fix For: 3.4.0
>
>
> The setter method take string[] as parameter which confuse the json
> serializer which character as separator. We should convert the string to
> string[] in setter method. Reserve , as seperator
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
