[
https://issues.apache.org/jira/browse/APEXCORE-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212731#comment-15212731
]
ASF GitHub Bot commented on APEXCORE-10:
----------------------------------------
Github user ishark commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/250#discussion_r57507404
--- Diff:
engine/src/main/java/com/datatorrent/stram/ContainerRequestHandler.java ---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.datatorrent.stram;
+
+import java.util.List;
+import java.util.Map;
+
+import org.apache.commons.lang3.tuple.MutablePair;
+import org.apache.hadoop.yarn.client.api.AMRMClient;
+import org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest;
+
+/**
+ * Handles creating container requests and reissuing them on timeout
+ *
+ */
+public class ContainerRequestHandler
+{
+ protected static final int NUMBER_MISSED_HEARTBEATS = 30;
+
+ public void reissueContainerRequests(AMRMClient<ContainerRequest>
amRmClient, Map<StreamingContainerAgent.ContainerStartRequest,
MutablePair<Integer, ContainerRequest>> requestedResources, int loopCounter,
ResourceRequestHandler resourceRequestor, List<ContainerRequest>
containerRequests, List<ContainerRequest> removedContainerRequests)
+ {
+ if (!requestedResources.isEmpty()) {
+ // resourceRequestor.clearNodeMapping();
+ for (Map.Entry<StreamingContainerAgent.ContainerStartRequest,
MutablePair<Integer, ContainerRequest>> entry : requestedResources.entrySet()) {
+ if ((loopCounter - entry.getValue().getKey()) >
NUMBER_MISSED_HEARTBEATS) {
--- End diff --
This flow actually did not change from previously. I just moved it in a
separate class. If container request was not honored by Yarn within this time
frame, we reissue the request. This class was added to provide an override for
Cloudera to manage Node specific request. Will update the Jira with these
details.
> Enable non-affinity of operators per node (not containers)
> ----------------------------------------------------------
>
> Key: APEXCORE-10
> URL: https://issues.apache.org/jira/browse/APEXCORE-10
> Project: Apache Apex Core
> Issue Type: Task
> Reporter: Amol Kekre
> Assignee: Isha Arkatkar
> Labels: roadmap
>
> The issue happens on cloud which provides virtual cores with software like
> Xen underneath. In effect if CPU intensive operators land up on same node we
> have a resource bottleneck,
> Need to create an attribute that does the following
> - Operators A & B should not be on same node
> - Stram should use this attribute to try to get containers on different node
> It is understood that the user is making an explicit choice to use NIC
> instead of stream local optimization
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
