Thumb rule for import order:
As you go down the import order; you have more and more control over making
changes to that code.

Considering this idea, separation of org.apache.apex makes sense.

+1 for org.apache.apex
+0 separating api imports.


~ Yogi

On 6 April 2016 at 11:19, Thomas Weise <[email protected]> wrote:

> Just wanted to know why, I have no preference.
>
> On Tue, Apr 5, 2016 at 10:48 PM, Chandni Singh <[email protected]>
> wrote:
>
> > We treated com.datatorrent in a special way earlier which is why I
> started
> > the discussion.
> > If we don't want to have anything special for org.apache.apex then there
> > will not be any change.
> >
> > Chandni
> >
> > On Tue, Apr 5, 2016 at 10:18 PM, Thomas Weise <[email protected]>
> > wrote:
> >
> > > Why do we need something special for org.apache.apex ?
> > >
> > >
> > > On Tue, Apr 5, 2016 at 10:15 PM, Chandni Singh <
> [email protected]>
> > > wrote:
> > >
> > > > +1 for Ram's suggestion :-)
> > > >
> > > > On Tue, Apr 5, 2016 at 5:18 PM, Munagala Ramanath <
> [email protected]
> > >
> > > > wrote:
> > > >
> > > > > I'd suggest keeping all the org.apache imports together and in
> > > > > lexicographic order.
> > > > >
> > > > > Ram
> > > > >
> > > > > On Tue, Apr 5, 2016 at 5:12 PM, Chandni Singh <
> > [email protected]
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > We need to include org.apache.apex in the import order that we
> have
> > > > right
> > > > > > now:
> > > > > >
> > > > > > *Current order:*
> > > > > > java
> > > > > > javax
> > > > > > org
> > > > > > org.apache
> > > > > > io
> > > > > > com
> > > > > > com.datatorrent
> > > > > > *
> > > > > > all static imports
> > > > > >
> > > > > > *Proposed order:*
> > > > > > java
> > > > > > javax
> > > > > > org
> > > > > > org.apache
> > > > > > io
> > > > > > com
> > > > > > com.datatorrent
> > > > > > org.apache.apex
> > > > > > *
> > > > > > all static imports
> > > > > >
> > > > > > Thanks,
> > > > > > Chandni
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to