[
https://issues.apache.org/jira/browse/APEXMALHAR-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265662#comment-15265662
]
ASF GitHub Bot commented on APEXMALHAR-2070:
--------------------------------------------
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/262#discussion_r61683322
--- Diff:
library/src/main/java/org/apache/apex/malhar/lib/state/spillable/Spillable.java
---
@@ -44,8 +45,10 @@
}
/**
- * This represents a spillable {@link java.util.Map}. The underlying
implementation
- * of this map uses the serialized representation of the key object as a
key. User's that receive an
+ * This represents a spillable {@link java.util.Map}. The
implementations assume
+ * that the fields from objects of type K that are serialized are the
same fields that are used in the
--- End diff --
I think the comment be simplified using K1 and K2. The assumption is that
k1.equals(k2) should be consistent with
k1.toByteArray().equals(k2.toByteArray())
> Create In Memory Implementation of ArrayList Multimap
> -----------------------------------------------------
>
> Key: APEXMALHAR-2070
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2070
> Project: Apache Apex Malhar
> Issue Type: Sub-task
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> - Create an in memory implementation of ArrayListMultimap
> - Add Spillable Multisets
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
