[
https://issues.apache.org/jira/browse/APEXMALHAR-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285087#comment-15285087
]
ASF GitHub Bot commented on APEXMALHAR-2084:
--------------------------------------------
Github user amberarrow commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/275#discussion_r63406074
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -413,33 +413,39 @@ public int getInitialPartitionCount()
return initialPartitionCount;
}
- public void setClusters(String clusters)
- {
- this.clusters = clusters.split(";");
- }
-
/**
* Same setting as bootstrap.servers property to KafkaConsumer
* refer to
http://kafka.apache.org/documentation.html#newconsumerconfigs
- * To support multi cluster, you can have multiple bootstrap.servers
separated by ";"
+ * To support multi cluster, you can have multiple elements in the array
*/
- public String getClusters()
+ public void setClusters(String[] clusters)
{
- return Joiner.on(';').join(clusters);
+ this.clusters = clusters;
}
- public void setTopics(String topics)
+ public String[] getClusters()
{
- this.topics =
Iterables.toArray(Splitter.on(',').trimResults().omitEmptyStrings().split(topics),
String.class);
+ return clusters;
}
/**
- * The topics the operator consumes, separate by','
+ * The topics the operator consumes
* Topic name can only contain ASCII alphanumerics, '.', '_' and '-'
*/
- public String getTopics()
+ public void setTopics(String[] topics)
+ {
--- End diff --
You can avoid creation of the intermediate ArrayList and compact the array
in place with something like this but
feel free to ignore if you like the original better:
{code}
int j = 0, len = topics.length;
for (int i = 0; i < len; ++i) {
if (null == topics[i] || 0 == topics[i].length()) continue;
if (i != j) topics[j] = topics[i];
++j;
}
this.topics = Arrays.copyOfRange(topics, 0, j);
{code}
> Getters and setters for Kafka are not consistent for topics and clusters
> ------------------------------------------------------------------------
>
> Key: APEXMALHAR-2084
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2084
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Bhupesh Chawda
> Assignee: Bhupesh Chawda
>
> The getters and setters in Kafka input operator in Malhar-kafka for the
> fields: topics and clusters are not consistent and may cause problems in down
> stream systems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
