[
https://issues.apache.org/jira/browse/APEXMALHAR-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288107#comment-15288107
]
ASF GitHub Bot commented on APEXMALHAR-2084:
--------------------------------------------
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/275#discussion_r63636939
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -413,33 +413,39 @@ public int getInitialPartitionCount()
return initialPartitionCount;
}
- public void setClusters(String clusters)
- {
- this.clusters = clusters.split(";");
- }
-
/**
* Same setting as bootstrap.servers property to KafkaConsumer
* refer to
http://kafka.apache.org/documentation.html#newconsumerconfigs
- * To support multi cluster, you can have multiple bootstrap.servers
separated by ";"
+ * To support multi cluster, you can have multiple elements in the array
*/
- public String getClusters()
+ public void setClusters(String[] clusters)
{
- return Joiner.on(';').join(clusters);
+ this.clusters = clusters;
--- End diff --
I have tested whether the configuration works in xml. This is verified
using a application test.
For UI component, I have just verified that it allows for one text box per
element in the array. However, I think we should wait on this pull request
until I can test it out end to end for the UI.
> Getters and setters for Kafka are not consistent for topics and clusters
> ------------------------------------------------------------------------
>
> Key: APEXMALHAR-2084
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2084
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Bhupesh Chawda
> Assignee: Bhupesh Chawda
>
> The getters and setters in Kafka input operator in Malhar-kafka for the
> fields: topics and clusters are not consistent and may cause problems in down
> stream systems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
