agree +1
On Thu, 23 Dec 2021 at 15:50, JinChao Shuai <shuaijinc...@apache.org> wrote: > > agree +1 > > YuanSheng Wang <membp...@apache.org> 于2021年12月22日周三 23:10写道： > > > agree +1 > > > > the Tengine is not active recently. > > > > > > On Wed, Dec 22, 2021 at 1:45 PM Bozhong Yu <imbozh...@gmail.com> wrote: > > > > > Agree, +1 to drop the support of Tengine > > > > > > Zhiyuan Ju <juzhiy...@apache.org> 于2021年12月21日周二 10:47写道： > > > > > > > > In the future, we may only support OpenResty 1.19+. > > > > > We don't have contributors who are familiar enough with Tengine. > > > > > > > > Agree with Zexuan and Zeping's thoughts on this, +1 to drop the support > > > of > > > > Tengine. > > > > > > > > Best Regards! > > > > @ Zhiyuan Ju <https://github.com/juzhiyuan> > > > > > > > > > > > > Tsangleslie <leslie.ts...@icloud.com.invalid> 于2021年12月20日周一 23:22写道： > > > > > > > > > Agreed. > > > > > One vote for dropping support for Tengine. > > > > > > > > > > > > > > > Leslie Tsang > > > > > leslie.ts...@icloud.com > > > > > > > > > > > On 20 Dec 2021, at 9:24 PM, Zeping Bai <bzp2...@apache.org> wrote: > > > > > > > > > > > > Hi, Zexuan. > > > > > > I fully agree with dropping this support. Continuing to support it > > > does > > > > > > us little good and makes it more difficult to maintain. Also, > > > according > > > > > > to you, we don't have contributors who are familiar enough with > > > > > > Tengine. So I think it's time to give up on it. > > > > > > > > > > > > Best regards! > > > > > > Zeping Bai @bzp2010 > > > > > > > > > > > > > > > > > > > > > > > > Zexuan Luo <spacewan...@apache.org> 于2021年12月20日周一 21:13写道： > > > > > > > > > > > >> As OpenResty is going to release 1.21.4, it is time to consider > > > > > >> dropping the support of Tengine. > > > > > >> > > > > > >> Although Tengine is still maintained (a bugfix is just merged this > > > > > >> month), IMHO there will be some benefits if we can drop the > > support > > > of > > > > > >> Tengine: > > > > > >> 1. The latest Tengine is still based on Nginx 1.18.0, which is > > > > > >> released years ago. > > > > > >> 2. The Tengine support of APISIX is contributed by a contributor > > who > > > > > >> is no longer active. The maintainers don't have much experience to > > > > > >> work with Tengine. > > > > > >> 3. Some feature of Tengine, like Dubbo proxy, is already supported > > > in > > > > > >> apisix-base. > > > > > >> 4. Some feature of APISIX requires apisix-base, which is not > > > supported > > > > > >> by Tengine. > > > > > >> > > > > > >> By dropping the support of Tengine, we can remove extra CI job and > > > > > >> version check, make the code simpler. In the future, we may only > > > > > >> support OpenResty 1.19+. > > > > > >> > > > > > >> What about your opinion? > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > -- > > > > *MembPhis* > > My GitHub: https://github.com/membphis > > Apache APISIX: https://github.com/apache/apisix > > > > > -- > Thanks, > Janko
