On Fri, Oct 12, 2001 at 05:44:38PM -0400, Jeff Trawick wrote: > no!!!!!!! Because of this, we're returning APR_CHILD_NOTDONE when a > child exits due to a signal (like SIGSEGV)... thus Apache isn't able > to see that the segfault happened and the log message is broken. > > The old code had this correct. If waitpid() returns >0, a child has > finished. The WIF...() macros are just to find out how it finished > (it chose to exit -- WIFEXITED, it got a signal -- WIFSIGNALED()).
Um, okay. Is this acceptable? -- justin Index: threadproc/unix/proc.c =================================================================== RCS file: /home/cvs/apr/threadproc/unix/proc.c,v retrieving revision 1.49 diff -u -r1.49 proc.c --- threadproc/unix/proc.c 2001/09/21 16:14:50 1.49 +++ threadproc/unix/proc.c 2001/10/13 15:00:27 @@ -390,9 +390,8 @@ if (exitcode != NULL) { *exitcode = WEXITSTATUS(exit_int); } - return APR_CHILD_DONE; } - return APR_CHILD_NOTDONE; + return APR_CHILD_DONE; } else if (pstatus == 0) { return APR_CHILD_NOTDONE;