Thanks, it works much better with that change.
One more question: do you have a way to get "before" and
"after" profile data for a request with a ridiculously
large number of header fields (e.g., 90 different Cookie
or Accept lines that need to get merged)?  A default httpd
config will allow up to a 100-line header, which is a large
enough 'n' to make me paranoid about O(n^2) DoS vulnerabilities.

Thanks,
Brian

Joe Schaefer wrote:

Brian Pane <[EMAIL PROTECTED]> writes:



I just applied the patch (both the APR and httpd parts) and ran
the httpd-test regression tests. Something is broken:



[...]



There were a lot of segfaults, too. It looks like the index
within the table is getting corrupted. Here's an example:



Yup- looks like I botched index_initialized in apr_table_overlay.
Try adding


   t->index_initialized = overlay->index_initialized;

to apr_tables.c line 1076; all tests pass for me now.

Very sorry about that. I'll gladly add a test for apr_table_overlay to the apr table tests in a followup patch.







Reply via email to