Greg Stein wrote:
We can mark them in the 0.9.x branch as deprecated, and we can simply yank
them from the 1.0 development line. The whole point of the major version
change is to flush out functions like this.

Yes. I was pointing out that they aren't marked as deprecated in 0.9.x

Same for apr_poll() for that matter. It should just go; Justin explained
the reasons/rationale very well.

I've never said that I didn't agree with the decision. I just found it odd that yanking was done without deprecating.


On Mon, Dec 08, 2003 at 05:18:26PM -0800, Stas Bekman wrote:

Greg Stein wrote:

+1 across the board.

On Tue, Dec 02, 2003 at 10:57:24AM -0500, Jeff Trawick wrote:


(or +1, as the case may be)

remove:
 apr_sockaddr_port_get() - caller can read from sockaddr directly
 apr_sockaddr_ip_set() - limitation of IPv4 n.a.s. is bogus
                       caller should use apr_sockaddr_info_get()

shrug:
 apr_sockaddr_port_set() - bad for caller to set in
                        sockaddr directly; I'm not sure how useful
                        it is to use apr_sockaddr_info_get() but
                        then change the port later

but leave:
 apr_sockaddr_ip_get() - this does interesting work that we don't
                       want to do ahead of time just in case
                       this info will be needed

Also, change the docs for apr_socket_connect() to remove the hint about passing NULL for the sockaddr.

There is a problem with doing this. These functions are not deprecated
in the 9.x branch. So you should at least commit .h fix that deprecates them. I don't think it's very developer-friendly to nuke public functions without first deprecating them.

__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com



Reply via email to