Stas Bekman wrote:
remove: apr_sockaddr_port_get() - caller can read from sockaddr directly apr_sockaddr_ip_set() - limitation of IPv4 n.a.s. is bogus caller should use apr_sockaddr_info_get()
shrug: apr_sockaddr_port_set() - bad for caller to set in sockaddr directly; I'm not sure how useful it is to use apr_sockaddr_info_get() but then change the port later
but leave: apr_sockaddr_ip_get() - this does interesting work that we don't want to do ahead of time just in case this info will be needed
Also, change the docs for apr_socket_connect() to remove the hint about passing NULL for the sockaddr.
There is a problem with doing this. These functions are not deprecated
in the 9.x branch. So you should at least commit .h fix that deprecates them.
done, good idea
I don't think it's very developer-friendly to nuke public functions without first deprecating them.
there is clearly an order problem though... yes we should mark things deprecated in 0.9 API definitions, as most removed or renamed things were, but if something different needs to be cleaned up for 1.0 API here at the last minute then there will be no advance warning
