On 04/03/2009 06:12 PM, Mladen Turk wrote: > Ruediger Pluem wrote: >> >> On 04/03/2009 04:31 PM, [email protected] wrote: >>> Author: mturk >>> Date: Fri Apr 3 14:31:16 2009 >>> New Revision: 761692 >>> >>> URL: http://svn.apache.org/viewvc?rev=761692&view=rev >>> Log: >>> Make final_block dynamic. >>> It is used only so we can create our mutex that will survive pool_clear >> >> Why? The original intention was to reduce malloc and free calls. Your >> change introduces additional ones for no real merit. At least I can see >> none. >> > > It reduces the pool size by one block_list_t > in 99.9% of the cases. > > This one is used only if you do: > > a = apr_allocator_create > p = apr_pool_create_ex( ... a) > > This peace of code is very rare.
Agreed. I read your comment on d...@apr *after* the commit. This comment already explained it to me. Thanks for describing it again. Regards Rüdiger
