On Fri, 8 Nov 2013 11:00:18 -0800 (PST) Arsen Chaloyan <[email protected]> wrote:
> Anyway, if it turns out the change has to be #ifdef-ed, which is most > likely, then testing _MSC_VER only is not enough or appropriate. > Please note, if one uses VS2013 (_MSC_VER == 1800), it doesn't > necessarily mean that the Platform Toolset v120 is being used. > Starting with VS2010, it's possible to choose one of the available > Platform Toolsets to build with. > > So, either _MSC_VER_FULL should be used or a new preprocessor > definition can be added, something like > _MSC_PT_VER=$(PlatformToolsetVersion) with further reference to > _MSC_PT_VER >= 120. Does this change apply to all flavors of the Platform Toolset? It sounds like that might be configured w/ older or later versions of MSC. E.g. can we simply look for #ifdef _MSC_PT_VER and presume the proposed patch will work correctly?
