Hi Ivan, On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov <[email protected]> wrote: > > This change does not compile on Windows in APR 1.7.x: > [[[ > file_io\win32\readwrite.c(325): error C2065: 'file': undeclared identifier > file_io\win32\readwrite.c(325): error C2223: left of '->filehand' must > point to struct/union
I was missing backport of r1895178, does r1896808 compile now? (Sorry, no Windows at hand..). > > I also have a high-level objection against backporting this change to > APR 1.7.x: IMHO APR 1.7.x is a stable branch and I think that only > regression fixes should be backported to the stable branch. r1896510 > is a significant change and as far as I understand it's not a > regression fix. So I think it would be better to revert r1896510 and > release it as part of APR 2.0 (or 1.8.x). I think that most if not all of the changes to 1.7.x since 1.7.0 are fixes for bugs that were there before 1.7 already, not regressions introduced by 1.7.0. But I'm fine with switching to 1.8.x and releasing 1.8.0 if that's the policy, not sure that 1.7.1 is needed then (and we'd need to revert quite some changes in 1.7.x..). Regards; Yann.
