Hi Andrea, This is really a question for Linus since he controls this kind of stuff, but I'll give you my opinions.
- Code that you work on should be brought into conformance with the current coding style. - Cleaning up poor structure, duplicate code, use of deprecated functions is a judgement call. It's always better to improve the code when it's worked on, but if you're focused on a different task, eg fixing a specific bug, I think it's OK to ignore this stuff. I know that if I look at the comment for a deprecation and can't easily figure out what change is required, I'll just leave the current usage for someone who is familiar with what needs to be done. - It's very important, particularly when beginning, to make your changes in small increments and not mix two types of changes together. This makes it much easier for others to review the changes. If there were just one or two long lines that needed to be wrapped, that could be done with whatever else you are working on, but if there are extensive code style cleanups or if refactoring is required, those should be committed separately from your bug fix/enhancement. - I don't think a new issue in the database is required if you do all the work immediately. If you identify an issue that you can't deal with or you will deal with over time, you should mark the code with a TODO: comment and. If it's a large or important task, create a new "Task" type issue in the database. Tom --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
