Hello Andrea!
Code is "fixed" or "improved upon" in much the same way as other
improvements.
If it is a small fix, like introducing a comment or reformatting, that
doesn't change anything (famous last words?) I do it without first
creating a test case. If it is more advanced things like duplicated
logic or use deprecated code I'd suggest a unit test created to check
that there is no change. A unit test is always welcome if there are any
doubts.
If you should do it or save it for someone else depends on your personal
agenda (or in your case the agenda that you and Michiel have set up for
you ;-).
Every change is not required to be stated in an issue. Issuezilla is
used to keep track of changes that need to be done to the code, not a
historic record of all changes. For a historic record we use the commit
comments. Most changes are triggered from issues in issuezilla but some
of the might not be. Especially changes because some static check (test
case or checkstyle) has found a problem, are not triggered from
issuezilla but from that tool.
We have configured checkstyle to adhere to the project rules so
checkstyle should just find problems where we violate the project rules.
If there are discrepancies in this, they should be fixed.
/Linus
> -----Original Message-----
> From: Niro [mailto:[EMAIL PROTECTED]
> Sent: den 3 juni 2006 14:56
> To: [email protected]
> Subject: [argouml-dev] code changes conventions...
>
> Hi to all!
> A simple question (kinda related to bug 4242): how do you manager
> "dirty" code? Consider this: you are working on a defect, involving
lot
> of fixes to different methods / classes.. and you notice that a method
> you're working on is dirty (i.e., does a duplicated logic, use
> deprecated code...). Do you fix it or leave as it is?
> I feel it should be changeable - of course, only after a unit test is
> created. And, if you modify it, do you insert a new issue - or
something
> similar?
>
> And what about project style? If you modify a method that doesn't
> conform to checkstyle rules, do you make it comply with the project
rules?
>
> Regards,
> Andrea
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
