rotty3000 commented on a change in pull request #133:
URL:
https://github.com/apache/aries-jax-rs-whiteboard/pull/133#discussion_r728134980
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/internal/client/ClientBuilderImpl.java
##########
@@ -19,9 +19,6 @@
import
org.apache.aries.jax.rs.whiteboard.cxf.jaxrs.client.PromiseRxInvokerProviderImpl;
-import aQute.bnd.annotation.spi.ServiceProvider;
-
-@ServiceProvider(javax.ws.rs.client.ClientBuilder.class)
Review comment:
because of this removal, given the following test:
```
@Test
public void testClientBuilderFromAPI() throws InterruptedException {
ClientBuilder clientBuilder = ClientBuilder.newBuilder();
assertNotNull(clientBuilder);
}
```
I get the following exception:
```
g! TEST testClientBuilderFromAPI(test.ProviderTest) <<< ERROR:
java.lang.ClassNotFoundException
java.lang.RuntimeException: java.lang.ClassNotFoundException
at javax.ws.rs.client.ClientBuilder.newBuilder(ClientBuilder.java:50)
at test.ProviderTest.testClientBuilderFromAPI(ProviderTest.java:30)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:50)
at junit.framework.TestSuite.runTest(TestSuite.java:241)
at junit.framework.TestSuite.run(TestSuite.java:236)
at aQute.junit.Activator.test(Activator.java:354)
at aQute.junit.Activator.automatic(Activator.java:266)
at aQute.junit.Activator.run(Activator.java:188)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at aQute.launcher.Launcher.launch(Launcher.java:452)
at aQute.launcher.Launcher.run(Launcher.java:185)
at aQute.launcher.Launcher.main(Launcher.java:161)
at
aQute.launcher.pre.EmbeddedLauncher.executeWithRunPath(EmbeddedLauncher.java:170)
at
aQute.launcher.pre.EmbeddedLauncher.findAndExecute(EmbeddedLauncher.java:135)
at aQute.launcher.pre.EmbeddedLauncher.main(EmbeddedLauncher.java:52)
Caused by: java.lang.ClassNotFoundException
at javax.ws.rs.client.ClientFinder.newInstance(ClientFinder.java:118)
at javax.ws.rs.client.ClientFinder.find(ClientFinder.java:94)
at javax.ws.rs.client.ClientBuilder.newBuilder(ClientBuilder.java:44)
... 34 more
Caused by: java.lang.InstantiationException
at
sun.reflect.InstantiationExceptionConstructorAccessorImpl.newInstance(InstantiationExceptionConstructorAccessorImpl.java:48)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at java.lang.Class.newInstance(Class.java:442)
at javax.ws.rs.client.ClientFinder.newInstance(ClientFinder.java:114)
... 36 more
```
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/internal/client/ClientBuilderImpl.java
##########
@@ -19,9 +19,6 @@
import
org.apache.aries.jax.rs.whiteboard.cxf.jaxrs.client.PromiseRxInvokerProviderImpl;
-import aQute.bnd.annotation.spi.ServiceProvider;
-
-@ServiceProvider(javax.ws.rs.client.ClientBuilder.class)
Review comment:
really? I do not get this error. Let me check what happens in github
actions.
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/internal/client/ClientBuilderImpl.java
##########
@@ -19,9 +19,6 @@
import
org.apache.aries.jax.rs.whiteboard.cxf.jaxrs.client.PromiseRxInvokerProviderImpl;
-import aQute.bnd.annotation.spi.ServiceProvider;
-
-@ServiceProvider(javax.ws.rs.client.ClientBuilder.class)
Review comment:
We only see an error on the `SseEventSourceBuilderImpl` scenario in CI.
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/internal/client/ClientBuilderImpl.java
##########
@@ -19,9 +19,6 @@
import
org.apache.aries.jax.rs.whiteboard.cxf.jaxrs.client.PromiseRxInvokerProviderImpl;
-import aQute.bnd.annotation.spi.ServiceProvider;
-
-@ServiceProvider(javax.ws.rs.client.ClientBuilder.class)
Review comment:
Further, I'm not questioning the need to fix the bug. I just don't want
to break existing behaviours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
