rotty3000 commented on a change in pull request #133:
URL:
https://github.com/apache/aries-jax-rs-whiteboard/pull/133#discussion_r729899038
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/package-info.java
##########
@@ -55,17 +68,25 @@
@Capability(
name = "javax.ws.rs.ext.RuntimeDelegate",
namespace = "osgi.serviceloader",
+ uses = javax.ws.rs.ext.RuntimeDelegate.class,
+ attribute = {
+ "register:=",
+ }
+)
+@Capability(
+ name = "javax.ws.rs.client.ClientBuilder",
+ namespace = "osgi.serviceloader",
+ uses = javax.ws.rs.client.ClientBuilder.class,
attribute = {
- "register:=org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl",
- "service.scope=prototype"
+ "register:=",
Review comment:
... cheeky fix
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/package-info.java
##########
@@ -55,17 +68,25 @@
@Capability(
name = "javax.ws.rs.ext.RuntimeDelegate",
namespace = "osgi.serviceloader",
+ uses = javax.ws.rs.ext.RuntimeDelegate.class,
+ attribute = {
+ "register:=",
Review comment:
this is a cheeky fix
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/package-info.java
##########
@@ -55,17 +68,25 @@
@Capability(
name = "javax.ws.rs.ext.RuntimeDelegate",
namespace = "osgi.serviceloader",
+ uses = javax.ws.rs.ext.RuntimeDelegate.class,
+ attribute = {
+ "register:=",
+ }
+)
+@Capability(
+ name = "javax.ws.rs.client.ClientBuilder",
+ namespace = "osgi.serviceloader",
+ uses = javax.ws.rs.client.ClientBuilder.class,
attribute = {
- "register:=org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl",
- "service.scope=prototype"
+ "register:=",
}
)
@Capability(
name = "javax.ws.rs.sse.SseEventSource.Builder",
namespace = "osgi.serviceloader",
+ uses = javax.ws.rs.sse.SseEventSource.Builder.class,
attribute = {
- "register:=org.apache.cxf.jaxrs.sse.client.SseEventSourceBuilderImpl",
- "service.scope=prototype"
+ "register:=",
Review comment:
... cheeky fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@aries.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
