amichair commented on code in PR #93: URL: https://github.com/apache/aries-rsa/pull/93#discussion_r3151530135
########## discovery/tcp/src/main/java/org/apache/aries/rsa/discovery/tcp/Interest.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.aries.rsa.discovery.tcp; Review Comment: I would agree in a project where there is a public api, like a utility library etc. But RSA, like several other osgi/compendium components, are more of a framework extension in that sense - there is no public api that clients access directly. They just deploy it in the osgi container and it 'magically works' for the most part, other than possibly some config admin or service properties that serve as configuration options. That said, if you have a better package arrangement in mind that would make the code easier to manage, let me know and I'll apply it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
