amichair commented on code in PR #93: URL: https://github.com/apache/aries-rsa/pull/93#discussion_r3151599106
########## discovery/tcp/src/main/java/org/apache/aries/rsa/discovery/tcp/InterestManager.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.aries.rsa.discovery.tcp; + +import org.osgi.framework.ServiceReference; +import org.osgi.service.remoteserviceadmin.EndpointDescription; +import org.osgi.service.remoteserviceadmin.EndpointEvent; +import org.osgi.service.remoteserviceadmin.EndpointEventListener; + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; + +import static org.osgi.service.remoteserviceadmin.EndpointEvent.*; + +/** + * Manages all known local EndpointEventListeners along with their interests (scopes), + * as well as all known remote endpoints, and notifies the former about the latter. + */ +public class InterestManager { + // listener to its interest Review Comment: I'm not sure why it's easy to lose comments, or how converting the comment style would affect this, but if this were the policy (to never use non-javadoc comments) it would have to be applied to all classes in the project, so it's beyond the scope of this PR. Making one change here would just make the codebase inconsistently-styled at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
